fix maybe-uninitialized error in serializer.cpp 88/208488/2
authorHimanshu Maithani <himanshu.m@samsung.com>
Tue, 25 Jun 2019 05:35:11 +0000 (11:05 +0530)
committerHyotaek Shim <hyotaek.shim@samsung.com>
Wed, 26 Jun 2019 05:13:24 +0000 (05:13 +0000)
Function Serializer::serialize(const std::string config_path, size_t &size) can
return nullptr in case of error, thus leaving size to be uninitialized.

[   50s] src/internal/serializer.cpp: In member function 'serialize':
[   50s] src/internal/serializer.cpp:133:50: error: 'size' may be used uninitialized in this function [-Werror=maybe-uninitialized]
[   50s]   output.write(reinterpret_cast<char *>(buf), size);
[   50s]                                                   ^
[   50s] src/internal/serializer.cpp:130:9: note: 'size' was declared here
[   50s]   size_t size

Change-Id: If8b2c735e6b01e73b592827b937e0dfe8f94a615
Signed-off-by: Himanshu Maithani <himanshu.m@samsung.com>
src/internal/serializer.cpp

index b2b5de9..726f0d4 100644 (file)
@@ -127,7 +127,7 @@ uint8_t* Serializer::serialize(const std::string config_path, size_t &size) {
 }
 
 uint8_t *Serializer::serialize(const std::string config_path, std::ostream &output) {
-       size_t size;
+       size_t size = 0;
        uint8_t *buf = serialize(config_path, size);
 
        output.write(reinterpret_cast<char *>(buf), size);