phy: core: Invoke pm_runtime_get_*/pm_runtime_put_* before invoking reset callback
authorKishon Vijay Abraham I <kishon@ti.com>
Fri, 5 Apr 2019 11:08:31 +0000 (16:38 +0530)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 17 Apr 2019 08:43:17 +0000 (14:13 +0530)
PHY drivers may try to access PHY registers in the ->reset() callback.
Invoke phy_pm_runtime_get_sync() before invoking the ->reset() callback
so that the PHY drivers don't have to enable clocks by themselves before
accessing PHY registers.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-core.c

index b9a4ebf..c147ba8 100644 (file)
@@ -384,10 +384,16 @@ int phy_reset(struct phy *phy)
        if (!phy || !phy->ops->reset)
                return 0;
 
+       ret = phy_pm_runtime_get_sync(phy);
+       if (ret < 0 && ret != -ENOTSUPP)
+               return ret;
+
        mutex_lock(&phy->mutex);
        ret = phy->ops->reset(phy);
        mutex_unlock(&phy->mutex);
 
+       phy_pm_runtime_put(phy);
+
        return ret;
 }
 EXPORT_SYMBOL_GPL(phy_reset);