Colorselector: Fix out of bound read.

high should be the last item of the array, not the length of the array.
As part of this change, I also changed the code to use the better way of
getting the array size.

CID1339827

diff --git a/legacy/elementary/src/lib/elm_colorselector.c b/legacy/elementary/src/lib/elm_colorselector.c
index d919e7b..8d69c63 100644 (file)
--- a/legacy/elementary/src/lib/elm_colorselector.c
+++ b/legacy/elementary/src/lib/elm_colorselector.c
@@ -203,7 +203,7 @@ _get_color_name (unsigned int R, unsigned int G, unsigned int B, unsigned int A)
 
    if (A != 255) return NULL;
    low = 0;
-   high = sizeof(_color_name)/ sizeof(_color_name[0]);
+   high = EINA_C_ARRAY_LENGTH(_color_name) - 1;
    while (low <= high)
      {
         mid = (low + high) / 2;