powerpc: Remove direct call to personality syscall handler
authorRohan McLure <rmclure@linux.ibm.com>
Wed, 21 Sep 2022 06:55:52 +0000 (16:55 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 26 Sep 2022 13:00:16 +0000 (23:00 +1000)
Syscall handlers should not be invoked internally by their symbol names,
as these symbols defined by the architecture-defined SYSCALL_DEFINE
macro. Fortunately, in the case of ppc64_personality, its call to
sys_personality can be replaced with an invocation to the
equivalent ksys_personality inline helper in <linux/syscalls.h>.

Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220921065605.1051927-13-rmclure@linux.ibm.com
arch/powerpc/kernel/syscalls.c

index 34e1ae8..a04c97f 100644 (file)
@@ -71,7 +71,7 @@ long ppc64_personality(unsigned long personality)
        if (personality(current->personality) == PER_LINUX32
            && personality(personality) == PER_LINUX)
                personality = (personality & ~PER_MASK) | PER_LINUX32;
-       ret = sys_personality(personality);
+       ret = ksys_personality(personality);
        if (personality(ret) == PER_LINUX32)
                ret = (ret & ~PER_MASK) | PER_LINUX;
        return ret;