usb: dwc3: gadget: Change condition for processing suspend event
authorPrashanth K <quic_prashk@quicinc.com>
Fri, 24 Feb 2023 05:46:58 +0000 (11:16 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Mar 2023 14:31:15 +0000 (15:31 +0100)
Currently we process the suspend interrupt event only if the
device is in configured state. Consider a case where device
is not configured and got suspend interrupt, in that case our
gadget will still use 100mA as composite_suspend didn't happen.
But battery charging specification (BC1.2) expects a downstream
device to draw less than 2.5mA when unconnected OR suspended.

Fix this by removing the condition for processing suspend event,
and thus composite_resume would set vbus draw to 2.

Fixes: 72704f876f50 ("dwc3: gadget: Implement the suspend entry event handler")
Signed-off-by: Prashanth K <quic_prashk@quicinc.com>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/1677217619-10261-2-git-send-email-quic_prashk@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c

index 3c63fa9..07989c6 100644 (file)
@@ -4239,15 +4239,8 @@ static void dwc3_gadget_interrupt(struct dwc3 *dwc,
                break;
        case DWC3_DEVICE_EVENT_SUSPEND:
                /* It changed to be suspend event for version 2.30a and above */
-               if (!DWC3_VER_IS_PRIOR(DWC3, 230A)) {
-                       /*
-                        * Ignore suspend event until the gadget enters into
-                        * USB_STATE_CONFIGURED state.
-                        */
-                       if (dwc->gadget->state >= USB_STATE_CONFIGURED)
-                               dwc3_gadget_suspend_interrupt(dwc,
-                                               event->event_info);
-               }
+               if (!DWC3_VER_IS_PRIOR(DWC3, 230A))
+                       dwc3_gadget_suspend_interrupt(dwc, event->event_info);
                break;
        case DWC3_DEVICE_EVENT_SOF:
        case DWC3_DEVICE_EVENT_ERRATIC_ERROR: