media: venus: hfi_venus: move set of default properties to core init
authorStanimir Varbanov <stanimir.varbanov@linaro.org>
Thu, 5 Jul 2018 13:03:43 +0000 (09:03 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 25 Jul 2018 12:45:48 +0000 (08:45 -0400)
This moves setting of default properties (firmware debug, idle
indicator and low power mode) from session init to core init.
All of those properties are need to be enabled/disabled early
so that they could be used before the clients are even initialized.

The other reason is to set idle indicator property early before
we enter into venus_suspend function where we need to check for
ARM9 WFI.

Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Tested-by: Alexandre Courbot <acourbot@chromium.org>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/platform/qcom/venus/hfi_venus.c

index 72a8547..7a83e96 100644 (file)
@@ -1091,6 +1091,10 @@ static int venus_core_init(struct venus_core *core)
        if (ret)
                dev_warn(dev, "failed to send image version pkt to fw\n");
 
+       ret = venus_sys_set_default_properties(hdev);
+       if (ret)
+               return ret;
+
        return 0;
 }
 
@@ -1135,10 +1139,6 @@ static int venus_session_init(struct venus_inst *inst, u32 session_type,
        struct hfi_session_init_pkt pkt;
        int ret;
 
-       ret = venus_sys_set_default_properties(hdev);
-       if (ret)
-               return ret;
-
        ret = pkt_session_init(&pkt, inst, session_type, codec);
        if (ret)
                goto err;