va: Validate JPEG subsampling configurations.

There are Mesa Gallium drivers that report subsampling but without
any pixel format. So, strip out these subsamplings.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2899>

diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.c b/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.c
index b83e488..c1f1661 100644 (file)
--- a/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.c
+++ b/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.c
@@ -252,6 +252,14 @@ gst_va_chroma_from_video_format (GstVideoFormat format)
   return map ? map->va_rtformat : 0;
 }
 
+guint
+gst_va_chroma_from_va_fourcc (guint va_fourcc)
+{
+  const struct FormatMap *map = get_format_map_from_va_fourcc (va_fourcc);
+
+  return map ? map->va_rtformat : 0;
+}
+
 const VAImageFormat *
 gst_va_image_format_from_video_format (GstVideoFormat format)
 {

diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.h b/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.h
index bda88df..609b27b 100644 (file)
--- a/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.h
+++ b/subprojects/gst-plugins-bad/gst-libs/gst/va/gstvavideoformat.h
@@ -37,6 +37,9 @@ GST_VA_API
 guint                 gst_va_chroma_from_video_format     (GstVideoFormat format);
 
 GST_VA_API
+guint                 gst_va_chroma_from_va_fourcc        (guint va_fourcc);
+
+GST_VA_API
 const VAImageFormat * gst_va_image_format_from_video_format (GstVideoFormat format);
 
 GST_VA_API

diff --git a/subprojects/gst-plugins-bad/sys/va/gstvacaps.c b/subprojects/gst-plugins-bad/sys/va/gstvacaps.c
index 71ab9c4..5fb95b9 100644 (file)
--- a/subprojects/gst-plugins-bad/sys/va/gstvacaps.c
+++ b/subprojects/gst-plugins-bad/sys/va/gstvacaps.c
@@ -264,10 +264,64 @@ gst_va_create_raw_caps (GstVaDisplay * display, VAProfile profile,
   return caps;
 }
 
+/* the purpose of this function is to find broken configurations in
+ * JPEG decoders: if the driver doesn't expose a pixel format for a
+ * config with a specific sampling, that sampling is not valid */
+static inline gboolean
+_config_has_pixel_formats (GstVaDisplay * display, VAProfile profile,
+    VAEntrypoint entrypoint, guint32 rt_format)
+{
+  guint i, fourcc, count;
+  gboolean found = FALSE;
+  VAConfigAttrib attrs = {
+    .type = VAConfigAttribRTFormat,
+    .value = rt_format,
+  };
+  VAConfigID config;
+  VADisplay dpy = gst_va_display_get_va_dpy (display);
+  VASurfaceAttrib *attr_list;
+  VAStatus status;
+
+  status = vaCreateConfig (dpy, profile, entrypoint, &attrs, 1, &config);
+  if (status != VA_STATUS_SUCCESS) {
+    GST_ERROR_OBJECT (display, "Failed to create JPEG config");
+    return FALSE;
+  }
+  attr_list = gst_va_get_surface_attribs (display, config, &count);
+  if (!attr_list)
+    goto bail;
+
+  /* XXX: JPEG decoders handle RGB16 and RGB32 chromas, but they use
+   * RGBP pixel format, which its chroma is RGBP (not 16 nor 32). So
+   * if the requested chroma is 16 or 32 it's locally overloaded as
+   * RGBP. */
+  if (rt_format == VA_RT_FORMAT_RGB16 || rt_format == VA_RT_FORMAT_RGB32)
+    rt_format = VA_RT_FORMAT_RGBP;
+
+  for (i = 0; i < count; i++) {
+    if (attr_list[i].type == VASurfaceAttribPixelFormat) {
+      fourcc = attr_list[i].value.value.i;
+      /* ignore pixel formats without requested chroma */
+      found = (gst_va_chroma_from_va_fourcc (fourcc) == rt_format);
+      if (found)
+        break;
+    }
+  }
+  g_free (attr_list);
+
+bail:
+  status = vaDestroyConfig (dpy, config);
+  if (status != VA_STATUS_SUCCESS)
+    GST_WARNING_OBJECT (display, "Failed to destroy JPEG config");
+
+  return found;
+}
+
 static void
-_add_jpeg_fields (GstCaps * caps, guint32 rt_formats)
+_add_jpeg_fields (GstVaDisplay * display, GstCaps * caps, VAProfile profile,
+    VAEntrypoint entrypoint, guint32 rt_formats)
 {
-  guint i;
+  guint i, size;
   GValue colorspace = G_VALUE_INIT, sampling = G_VALUE_INIT;
   gboolean rgb, gray, yuv;
 
@@ -278,7 +332,11 @@ _add_jpeg_fields (GstCaps * caps, guint32 rt_formats)
 
   for (i = 0; rt_formats && i < G_N_ELEMENTS (va_rt_format_list); i++) {
     if (rt_formats & va_rt_format_list[i]) {
-#define APPEND_YUV do { \
+      if (!_config_has_pixel_formats (display, profile, entrypoint,
+              va_rt_format_list[i]))
+        continue;
+
+#define APPEND_YUV do {                                                 \
         if (!yuv) { _value_list_append_string (&colorspace, "sYUV"); yuv = TRUE; } \
       } while (0)
 
@@ -323,17 +381,19 @@ _add_jpeg_fields (GstCaps * caps, guint32 rt_formats)
     }
   }
 
-  if (gst_value_list_get_size (&colorspace) == 1) {
+  size = gst_value_list_get_size (&colorspace);
+  if (size == 1) {
     gst_caps_set_value (caps, "colorspace",
         gst_value_list_get_value (&colorspace, 0));
-  } else {
+  } else if (size > 1) {
     gst_caps_set_value (caps, "colorspace", &colorspace);
   }
 
-  if (gst_value_list_get_size (&sampling) == 1) {
+  size = gst_value_list_get_size (&sampling);
+  if (size == 1) {
     gst_caps_set_value (caps, "sampling",
         gst_value_list_get_value (&sampling, 0));
-  } else {
+  } else if (size > 1) {
     gst_caps_set_value (caps, "sampling", &sampling);
   }
 
@@ -397,7 +457,7 @@ gst_va_create_coded_caps (GstVaDisplay * display, VAProfile profile,
     return NULL;
 
   if (rt_formats > 0 && gst_va_profile_codec (profile) == JPEG)
-    _add_jpeg_fields (caps, rt_formats);
+    _add_jpeg_fields (display, caps, profile, entrypoint, rt_formats);
 
   if (max_width == -1 || max_height == -1)
     return caps;