Disable Microsoft.Diagnostics.NETCore.Client.WriteAllDumpTypesTest (#934)

Given dotnet/diagnostics#913 I'm disabling this test until it can get investigated.

This path is exerted in @d366deb src/Tools/dotnet-dump/Dumper.cs:77 and dotnet-dump has several tests for collecting dump types, so even if we disable the test, we will still get some coverage.

diff --git a/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs b/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs
index f438f882c1c1d0a3eac28eae32166b9efcd75683..fb06c1528210d081d6ecaf6051fe4a8b59999e1f 100644 (file)
--- a/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs
+++ b/src/tests/Microsoft.Diagnostics.NETCore.Client/WriteDumpTests.cs
@@ -54,7 +54,7 @@ namespace Microsoft.Diagnostics.NETCore.Client
         /// <summary>
         /// A test that writes all the different types of dump file
         /// </summary>
-        [Fact]
+        [Fact(Skip = "Test often times out in official builds/PRs. See https://github.com/dotnet/diagnostics/issues/913")]
         public void WriteAllDumpTypesTest()
         {
             var normalDumpPath = "./myDump-normal.dmp";