USB: host: ehci-npcm7xx: Fix some error codes in probe
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 27 Jun 2018 08:37:05 +0000 (11:37 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Jun 2018 10:32:42 +0000 (19:32 +0900)
We accidentally return 1 instead of negative error codes.

Fixes: df44831ee2dd ("USB host: Add USB ehci support for nuvoton npcm7xx platform")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Avi Fishman <AviFishman70@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/host/ehci-npcm7xx.c

index c80a879..adaf8fb 100644 (file)
@@ -74,14 +74,14 @@ static int npcm7xx_ehci_hcd_drv_probe(struct platform_device *pdev)
        if (IS_ERR(gcr_regmap)) {
                dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-gcr\n",
                        __func__);
-               return IS_ERR(gcr_regmap);
+               return PTR_ERR(gcr_regmap);
        }
 
        rst_regmap = syscon_regmap_lookup_by_compatible("nuvoton,npcm750-rst");
        if (IS_ERR(rst_regmap)) {
                dev_err(&pdev->dev, "%s: failed to find nuvoton,npcm750-rst\n",
                        __func__);
-               return IS_ERR(rst_regmap);
+               return PTR_ERR(rst_regmap);
        }
 
        /********* phy init  ******/