[STYLE] Fix preload_threads_get_drop

Change-Id: If63f4874ff48ebe1f57221667a194d70c1a6bf15

diff --git a/preload/preload_module.c b/preload/preload_module.c
index b23e38d..759d46f 100644 (file)
--- a/preload/preload_module.c
+++ b/preload/preload_module.c
@@ -777,7 +777,6 @@ static int write_msg_handler(struct kprobe *p, struct pt_regs *regs)
        unsigned long caller_offset;
        unsigned long call_type_offset;
        unsigned long caller_addr;
-       bool drop;
        int ret;
 
        /* FIXME: swap_get_uarg uses get_user(), it might sleep */
@@ -793,8 +792,8 @@ static int write_msg_handler(struct kprobe *p, struct pt_regs *regs)
                return 0;
        }
 
-       ret = preload_threads_get_drop(current, &drop);
-       if (ret == 0 && drop)
+       ret = preload_threads_get_drop(current);
+       if (ret > 0)
                return 0;
 
        buf = kmalloc(len, GFP_ATOMIC);

diff --git a/preload/preload_threads.c b/preload/preload_threads.c
index b8c2b77..c700b96 100644 (file)
--- a/preload/preload_threads.c
+++ b/preload/preload_threads.c
@@ -257,14 +257,14 @@ get_call_type_done:
        return ret;
 }
 
-int preload_threads_get_drop(struct task_struct *task, bool *drop)
+int preload_threads_get_drop(struct task_struct *task)
 {
        struct thread_slot *slot;
        int ret = 0;
 
        slot = __get_task_slot(task);
        if (slot != NULL) {
-               *drop = slot->drop;
+               ret = (int) slot->drop;
                goto get_drop_done;
        }
 

diff --git a/preload/preload_threads.h b/preload/preload_threads.h
index 9020fb8..a82c0e6 100644 (file)
--- a/preload/preload_threads.h
+++ b/preload/preload_threads.h
@@ -13,7 +13,7 @@ int preload_threads_set_data(struct task_struct *task, unsigned long caller,
 int preload_threads_get_caller(struct task_struct *task, unsigned long *caller);
 int preload_threads_get_call_type(struct task_struct *task,
                                  unsigned char *call_type);
-int preload_threads_get_drop(struct task_struct *task, bool *drop);
+int preload_threads_get_drop(struct task_struct *task);
 bool preload_threads_check_disabled_probe(struct task_struct *task,
                                          unsigned long addr);
 void preload_threads_enable_probe(struct task_struct *task, unsigned long addr);