scsi: hisi_sas: Print SAS address for v3 hw erroneous completion print
authorLuo Jiaxing <luojiaxing@huawei.com>
Tue, 6 Apr 2021 11:48:27 +0000 (19:48 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 13 Apr 2021 03:21:26 +0000 (23:21 -0400)
To help debugging efforts, print the device SAS address for v3 hw erroneous
completion log.

Here is an example print:

hisi_sas_v3_hw 0000:b4:02.0: erroneous completion iptt=2193 task=000000002b0c13f8 dev id=17 addr=570fd45f9d17b001

Link: https://lore.kernel.org/r/1617709711-195853-3-git-send-email-john.garry@huawei.com
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

index 4580e08..51187dd 100644 (file)
@@ -2252,8 +2252,9 @@ static void slot_complete_v3_hw(struct hisi_hba *hisi_hba,
 
                slot_err_v3_hw(hisi_hba, task, slot);
                if (ts->stat != SAS_DATA_UNDERRUN)
-                       dev_info(dev, "erroneous completion iptt=%d task=%pK dev id=%d CQ hdr: 0x%x 0x%x 0x%x 0x%x Error info: 0x%x 0x%x 0x%x 0x%x\n",
+                       dev_info(dev, "erroneous completion iptt=%d task=%pK dev id=%d addr=%016llx CQ hdr: 0x%x 0x%x 0x%x 0x%x Error info: 0x%x 0x%x 0x%x 0x%x\n",
                                 slot->idx, task, sas_dev->device_id,
+                                SAS_ADDR(device->sas_addr),
                                 dw0, dw1, complete_hdr->act, dw3,
                                 error_info[0], error_info[1],
                                 error_info[2], error_info[3]);