USB: serial: visor: convert dbg() to dev_dbg()
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 May 2012 23:40:45 +0000 (16:40 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 May 2012 23:40:45 +0000 (16:40 -0700)
This removes most of the dbg() calls, as they were just tracing calls,
and converts the remaining ones to dev_dbg().

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/visor.c

index aa8911d..d9b41fa 100644 (file)
@@ -239,8 +239,6 @@ static int visor_open(struct tty_struct *tty, struct usb_serial_port *port)
 {
        int result = 0;
 
-       dbg("%s - port %d", __func__, port->number);
-
        if (!port->read_urb) {
                /* this is needed for some brain dead Sony devices */
                dev_err(&port->dev, "Device lied about number of ports, please use a lower one.\n");
@@ -253,7 +251,7 @@ static int visor_open(struct tty_struct *tty, struct usb_serial_port *port)
                goto exit;
 
        if (port->interrupt_in_urb) {
-               dbg("%s - adding interrupt input for treo", __func__);
+               dev_dbg(&port->dev, "adding interrupt input for treo\n");
                result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
                if (result)
                        dev_err(&port->dev,
@@ -269,8 +267,6 @@ static void visor_close(struct usb_serial_port *port)
 {
        unsigned char *transfer_buffer;
 
-       dbg("%s - port %d", __func__, port->number);
-
        /* shutdown our urbs */
        usb_serial_generic_close(port);
        usb_kill_urb(port->interrupt_in_urb);
@@ -305,12 +301,12 @@ static void visor_read_int_callback(struct urb *urb)
        case -ENOENT:
        case -ESHUTDOWN:
                /* this urb is terminated, clean up */
-               dbg("%s - urb shutting down with status: %d",
-                   __func__, status);
+               dev_dbg(&port->dev, "%s - urb shutting down with status: %d\n",
+                       __func__, status);
                return;
        default:
-               dbg("%s - nonzero urb status received: %d",
-                   __func__, status);
+               dev_dbg(&port->dev, "%s - nonzero urb status received: %d\n",
+                       __func__, status);
                goto exit;
        }
 
@@ -343,8 +339,6 @@ static int palm_os_3_probe(struct usb_serial *serial,
        int i;
        int num_ports = 0;
 
-       dbg("%s", __func__);
-
        transfer_buffer = kmalloc(sizeof(*connection_info), GFP_KERNEL);
        if (!transfer_buffer) {
                dev_err(dev, "%s - kmalloc(%Zd) failed.\n", __func__,
@@ -440,8 +434,6 @@ static int palm_os_4_probe(struct usb_serial *serial,
        unsigned char *transfer_buffer;
        int retval;
 
-       dbg("%s", __func__);
-
        transfer_buffer =  kmalloc(sizeof(*connection_info), GFP_KERNEL);
        if (!transfer_buffer) {
                dev_err(dev, "%s - kmalloc(%Zd) failed.\n", __func__,
@@ -473,8 +465,6 @@ static int visor_probe(struct usb_serial *serial,
        int (*startup)(struct usb_serial *serial,
                                        const struct usb_device_id *id);
 
-       dbg("%s", __func__);
-
        /*
         * some Samsung Android phones in modem mode have the same ID
         * as SPH-I500, but they are ACM devices, so dont bind to them
@@ -516,8 +506,6 @@ static int clie_3_5_startup(struct usb_serial *serial)
        int result;
        u8 *data;
 
-       dbg("%s", __func__);
-
        data = kmalloc(1, GFP_KERNEL);
        if (!data)
                return -ENOMEM;
@@ -580,8 +568,6 @@ static int treo_attach(struct usb_serial *serial)
                (serial->num_interrupt_in == 0))
                return 0;
 
-       dbg("%s", __func__);
-
        /*
        * It appears that Treos and Kyoceras want to use the
        * 1st bulk in endpoint to communicate with the 2nd bulk out endpoint,
@@ -617,8 +603,6 @@ static int clie_5_attach(struct usb_serial *serial)
        unsigned int pipe;
        int j;
 
-       dbg("%s", __func__);
-
        /* TH55 registers 2 ports.
           Communication in from the UX50/TH55 uses bulk_in_endpointAddress
           from port 0. Communication out to the UX50/TH55 uses