spi: add missing pci_dev_put() before return
authorWang Qing <wangqing@vivo.com>
Tue, 15 Feb 2022 02:00:07 +0000 (18:00 -0800)
committerMark Brown <broonie@kernel.org>
Wed, 23 Feb 2022 02:04:17 +0000 (02:04 +0000)
pci_get_slot() increases its reference count, the caller must
decrement the reference count by calling pci_dev_put()

Signed-off-by: Wang Qing <wangqing@vivo.com>
Link: https://lore.kernel.org/r/1644890407-65167-1-git-send-email-wangqing@vivo.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-topcliff-pch.c

index 8c4615b..8e1cc34 100644 (file)
@@ -877,7 +877,7 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
                dev_err(&data->master->dev,
                        "ERROR: dma_request_channel FAILS(Tx)\n");
                data->use_dma = 0;
-               return;
+               goto out;
        }
        dma->chan_tx = chan;
 
@@ -894,9 +894,12 @@ static void pch_spi_request_dma(struct pch_spi_data *data, int bpw)
                dma_release_channel(dma->chan_tx);
                dma->chan_tx = NULL;
                data->use_dma = 0;
-               return;
+               goto out;
        }
        dma->chan_rx = chan;
+
+out:
+       pci_dev_put(dma_dev);
 }
 
 static void pch_spi_release_dma(struct pch_spi_data *data)