staging: comedi: quatech_daqp_cs: there are 4 digital inputs
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Mon, 5 Oct 2015 21:22:49 +0000 (14:22 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Oct 2015 04:16:05 +0000 (21:16 -0700)
This board has 4 digital inputs not 1. Fix the subdevice init.

The digital input lines are shared with other functions. Add a
comment about this.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/quatech_daqp_cs.c

index a4a5244..b2effb8 100644 (file)
@@ -741,10 +741,21 @@ static int daqp_auto_attach(struct comedi_device *dev,
        if (ret)
                return ret;
 
+       /*
+        * Digital Input subdevice
+        * NOTE: The digital input lines are shared:
+        *
+        * Chan  Normal Mode        Expansion Mode
+        * ----  -----------------  ----------------------------
+        *  0    DI0, ext. trigger  Same as normal mode
+        *  1    DI1                External gain select, lo bit
+        *  2    DI2, ext. clock    Same as normal mode
+        *  3    DI3                External gain select, hi bit
+        */
        s = &dev->subdevices[2];
        s->type         = COMEDI_SUBD_DI;
        s->subdev_flags = SDF_READABLE;
-       s->n_chan       = 1;
+       s->n_chan       = 4;
        s->maxdata      = 1;
        s->insn_bits    = daqp_di_insn_bits;