mtd: maps: Fix refcount leak in of_flash_probe_versatile
authorMiaoqian Lin <linmq006@gmail.com>
Mon, 23 May 2022 14:02:05 +0000 (18:02 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:23:38 +0000 (14:23 +0200)
[ Upstream commit 33ec82a6d2b119938f26e5c8040ed5d92378eb54 ]

of_find_matching_node_and_match() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20220523140205.48625-1-linmq006@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mtd/maps/physmap-versatile.c

index ad7cd9c..297a509 100644 (file)
@@ -207,6 +207,7 @@ int of_flash_probe_versatile(struct platform_device *pdev,
 
                versatile_flashprot = (enum versatile_flashprot)devid->data;
                rmap = syscon_node_to_regmap(sysnp);
+               of_node_put(sysnp);
                if (IS_ERR(rmap))
                        return PTR_ERR(rmap);