adapter: Fix possible crash when stopping discovery

If the client disconnect/crash while MGMT_OP_STOP_DISCOVERY was pending
it would possibly cause a crash as the client pointer is passed to
mgmt_send and accessed in the callback after being freed.

To fix this the adapter itself is now passed to the callback so the
client is not accessed directly, instead the code now checks if
discovery_list has not been cleared in the meantime and only then
proceed to access the client pointer which is how
MGMT_OP_START_DISCOVERY is handled.

Signed-off-by: Anuj Jain <anuj01.jain@samsung.com>
Signed-off-by: Ayush Garg <ayush.garg@samsung.com>

diff --git a/src/adapter.c b/src/adapter.c
index 646522b..f14fd45 100644 (file)
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -2772,11 +2772,19 @@ done:
 static void stop_discovery_complete(uint8_t status, uint16_t length,
                                        const void *param, void *user_data)
 {
-       struct watch_client *client = user_data;
-       struct btd_adapter *adapter = client->adapter;
+       struct btd_adapter *adapter = user_data;
+       struct watch_client *client;
 
        DBG("status 0x%02x", status);
 
+       /* Is there are no clients the discovery must have been stopped while
+        * discovery command was pending.
+        */
+       if (!adapter->discovery_list)
+               return;
+
+       client = adapter->discovery_list->data;
+
        discovery_reply(client, status);
 
        if (status != MGMT_STATUS_SUCCESS)