ASoC: soc-pcm.c: summarize related settings at soc_new_pcm()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mon, 22 Aug 2022 02:46:25 +0000 (02:46 +0000)
committerMark Brown <broonie@kernel.org>
Mon, 22 Aug 2022 13:07:21 +0000 (14:07 +0100)
soc_new_pcm() sets pcm->no_device_suspend, but it sets other pcm->xxx
at the same function with different timing.
pcm->no_device_suspend setup timing has no effect. This patch tidyup it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87bksdgflq.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-pcm.c

index 4f60c0a..209dfa4 100644 (file)
@@ -2907,6 +2907,7 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
        rtd->pcm = pcm;
        pcm->nonatomic = rtd->dai_link->nonatomic;
        pcm->private_data = rtd;
+       pcm->no_device_suspend = true;
 
        if (rtd->dai_link->no_pcm || rtd->dai_link->params) {
                if (playback)
@@ -2961,8 +2962,6 @@ int soc_new_pcm(struct snd_soc_pcm_runtime *rtd, int num)
        ret = snd_soc_pcm_component_new(rtd);
        if (ret < 0)
                return ret;
-
-       pcm->no_device_suspend = true;
 out:
        dev_dbg(rtd->card->dev, "%s <-> %s mapping ok\n",
                soc_codec_dai_name(rtd), soc_cpu_dai_name(rtd));