arm64: dts: hisilicon: Add missing cooling device properties for CPUs
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 25 May 2018 05:40:03 +0000 (11:10 +0530)
committerWei Xu <xuwei5@hisilicon.com>
Tue, 17 Jul 2018 12:56:45 +0000 (13:56 +0100)
The cooling device properties, like "#cooling-cells" and
"dynamic-power-coefficient", should either be present for all the CPUs
of a cluster or none. If these are present only for a subset of CPUs of
a cluster then things will start falling apart as soon as the CPUs are
brought online in a different order. For example, this will happen
because the operating system looks for such properties in the CPU node
it is trying to bring up, so that it can register a cooling device.

Add such missing properties.

Do minor rearrangement as well to keep ordering consistent.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Wei Xu <xuwei5@hisilicon.com>
arch/arm64/boot/dts/hisilicon/hi6220.dtsi

index 586b281..247024d 100644 (file)
@@ -88,8 +88,8 @@
                        next-level-cache = <&CLUSTER0_L2>;
                        clocks = <&stub_clock 0>;
                        operating-points-v2 = <&cpu_opp_table>;
-                       #cooling-cells = <2>; /* min followed by max */
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
                        dynamic-power-coefficient = <311>;
                };
 
                        next-level-cache = <&CLUSTER0_L2>;
                        operating-points-v2 = <&cpu_opp_table>;
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
+                       dynamic-power-coefficient = <311>;
                };
 
                cpu2: cpu@2 {
                        next-level-cache = <&CLUSTER0_L2>;
                        operating-points-v2 = <&cpu_opp_table>;
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
+                       dynamic-power-coefficient = <311>;
                };
 
                cpu3: cpu@3 {
                        next-level-cache = <&CLUSTER0_L2>;
                        operating-points-v2 = <&cpu_opp_table>;
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
+                       dynamic-power-coefficient = <311>;
                };
 
                cpu4: cpu@100 {
                        next-level-cache = <&CLUSTER1_L2>;
                        operating-points-v2 = <&cpu_opp_table>;
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
+                       dynamic-power-coefficient = <311>;
                };
 
                cpu5: cpu@101 {
                        next-level-cache = <&CLUSTER1_L2>;
                        operating-points-v2 = <&cpu_opp_table>;
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
+                       dynamic-power-coefficient = <311>;
                };
 
                cpu6: cpu@102 {
                        next-level-cache = <&CLUSTER1_L2>;
                        operating-points-v2 = <&cpu_opp_table>;
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
+                       dynamic-power-coefficient = <311>;
                };
 
                cpu7: cpu@103 {
                        next-level-cache = <&CLUSTER1_L2>;
                        operating-points-v2 = <&cpu_opp_table>;
                        cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
+                       #cooling-cells = <2>; /* min followed by max */
+                       dynamic-power-coefficient = <311>;
                };
 
                CLUSTER0_L2: l2-cache0 {