powerpc: Replace cpu_up/down() with add/remove_cpu()
authorQais Yousef <qais.yousef@arm.com>
Mon, 23 Mar 2020 13:51:03 +0000 (13:51 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 25 Mar 2020 11:59:35 +0000 (12:59 +0100)
The core device API performs extra housekeeping bits that are missing
from directly calling cpu_up/down.

See commit a6717c01ddc2 ("powerpc/rtas: use device model APIs and
serialization during LPM") for an example description of what might go
wrong.

This also prepares to make cpu_up/down() a private interface of the CPU
subsystem.

Signed-off-by: Qais Yousef <qais.yousef@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lkml.kernel.org/r/20200323135110.30522-11-qais.yousef@arm.com
arch/powerpc/kexec/core_64.c

index 04a7cba..b418409 100644 (file)
@@ -212,7 +212,7 @@ static void wake_offline_cpus(void)
                if (!cpu_online(cpu)) {
                        printk(KERN_INFO "kexec: Waking offline cpu %d.\n",
                               cpu);
-                       WARN_ON(cpu_up(cpu));
+                       WARN_ON(add_cpu(cpu));
                }
        }
 }