watchdog: pcwd_pci: mark expected switch fall-through
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 3 Nov 2017 16:02:30 +0000 (11:02 -0500)
committerWim Van Sebroeck <wim@iguana.be>
Thu, 28 Dec 2017 19:45:29 +0000 (20:45 +0100)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Notice that in this particular case I replaced "Fall" with a proper
"fall through" comment, which is what GCC is expecting to find.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
drivers/watchdog/pcwd_pci.c

index c0d07ee..1f78f09 100644 (file)
@@ -545,8 +545,8 @@ static long pcipcwd_ioctl(struct file *file, unsigned int cmd,
                        return -EINVAL;
 
                pcipcwd_keepalive();
-               /* Fall */
        }
+               /* fall through */
 
        case WDIOC_GETTIMEOUT:
                return put_user(heartbeat, p);