drm/amdgpu: Remove clock gating restore.
authorAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Wed, 4 Sep 2019 15:16:24 +0000 (11:16 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 13 Sep 2019 22:50:10 +0000 (17:50 -0500)
Restoring clock gating break SMU opeartion afterwards, avoid
this until this further invistigated with SMU.

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Tao Zhou <tao.zhou1@amd.com>
Reviewed-and-tested-by: Guchun Chen <guchun.chen@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c

index 4a59510..c44723c 100644 (file)
@@ -493,7 +493,15 @@ static void smu_v11_0_i2c_fini(struct i2c_adapter *control)
        }
 
        /* Restore clock gating */
-       smu_v11_0_i2c_set_clock_gating(control, true);
+
+       /*
+        * TODO Reenabling clock gating seems to break subsequent SMU operation
+        *      on the I2C bus. My guess is that SMU doesn't disable clock gating like
+        *      we do here before working with the bus. So for now just don't restore
+        *      it but later work with SMU to see if they have this issue and can
+        *      update their code appropriately
+        */
+       /* smu_v11_0_i2c_set_clock_gating(control, true); */
 
 }