KVM: x86/vPMU: reset pmc->counter to 0 for pmu fixed_counters
authorLike Xu <like.xu@linux.intel.com>
Wed, 17 Jul 2019 02:51:18 +0000 (10:51 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Wed, 17 Jul 2019 10:23:20 +0000 (12:23 +0200)
To avoid semantic inconsistency, the fixed_counters in Intel vPMU
need to be reset to 0 in intel_pmu_reset() as gp_counters does.

Signed-off-by: Like Xu <like.xu@linux.intel.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/vmx/pmu_intel.c

index 68d231d49c7acf0f916791226bb1908048f8957f..4dea0e0e7e392cb9de5771347604d99c126d24b4 100644 (file)
@@ -337,17 +337,22 @@ static void intel_pmu_init(struct kvm_vcpu *vcpu)
 static void intel_pmu_reset(struct kvm_vcpu *vcpu)
 {
        struct kvm_pmu *pmu = vcpu_to_pmu(vcpu);
+       struct kvm_pmc *pmc = NULL;
        int i;
 
        for (i = 0; i < INTEL_PMC_MAX_GENERIC; i++) {
-               struct kvm_pmc *pmc = &pmu->gp_counters[i];
+               pmc = &pmu->gp_counters[i];
 
                pmc_stop_counter(pmc);
                pmc->counter = pmc->eventsel = 0;
        }
 
-       for (i = 0; i < INTEL_PMC_MAX_FIXED; i++)
-               pmc_stop_counter(&pmu->fixed_counters[i]);
+       for (i = 0; i < INTEL_PMC_MAX_FIXED; i++) {
+               pmc = &pmu->fixed_counters[i];
+
+               pmc_stop_counter(pmc);
+               pmc->counter = 0;
+       }
 
        pmu->fixed_ctr_ctrl = pmu->global_ctrl = pmu->global_status =
                pmu->global_ovf_ctrl = 0;