rtc: sysfs: check features instead of ops
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 29 Apr 2021 21:44:03 +0000 (23:44 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 29 Apr 2021 21:51:18 +0000 (23:51 +0200)
Test RTC_FEATURE_ALARM instead of relying on .set_alarm to know whether
alarms are available.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20210429214403.2610952-1-alexandre.belloni@bootlin.com
drivers/rtc/sysfs.c

index 8a957d3..74026f6 100644 (file)
@@ -273,7 +273,7 @@ static bool rtc_does_wakealarm(struct rtc_device *rtc)
        if (!device_can_wakeup(rtc->dev.parent))
                return false;
 
-       return rtc->ops->set_alarm != NULL;
+       return !!test_bit(RTC_FEATURE_ALARM, rtc->features);
 }
 
 static umode_t rtc_attr_is_visible(struct kobject *kobj,