ASoC: ops: Reject out of bounds values in snd_soc_put_xr_sx()
authorMark Brown <broonie@kernel.org>
Mon, 24 Jan 2022 15:32:53 +0000 (15:32 +0000)
committerMark Brown <broonie@kernel.org>
Tue, 25 Jan 2022 10:21:36 +0000 (10:21 +0000)
We don't currently validate that the values being set are within the range
we advertised to userspace as being valid, do so and reject any values
that are out of range.

Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20220124153253.3548853-4-broonie@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-ops.c

index c31e63b27193c62aac2cdd0fca4c2d27aa6c2752..dc0e7c8d31f37832deb1e317e27d48c790fc4c61 100644 (file)
@@ -879,6 +879,8 @@ int snd_soc_put_xr_sx(struct snd_kcontrol *kcontrol,
        long val = ucontrol->value.integer.value[0];
        unsigned int i;
 
+       if (val < mc->min || val > mc->max)
+               return -EINVAL;
        if (invert)
                val = max - val;
        val &= mask;