usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()
authorTang Bin <tangbin@cmss.chinamobile.com>
Fri, 10 Apr 2020 01:58:32 +0000 (09:58 +0800)
committerFelipe Balbi <balbi@kernel.org>
Mon, 25 May 2020 08:09:43 +0000 (11:09 +0300)
If the function "platform_get_irq()" failed, the negative value
returned will not be detected here, including "-EPROBE_DEFER", which
causes the application to fail to get the correct error message.
Thus it must be fixed.

Acked-by: Li Yang <leoyang.li@nxp.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
drivers/usb/gadget/udc/fsl_udc_core.c

index febabde62f71a790e98835d5616d63a4d41d679a..b2638e83bb49898dc10706cdda9d5c10e706b803 100644 (file)
@@ -2440,8 +2440,8 @@ static int fsl_udc_probe(struct platform_device *pdev)
        udc_controller->max_ep = (dccparams & DCCPARAMS_DEN_MASK) * 2;
 
        udc_controller->irq = platform_get_irq(pdev, 0);
-       if (!udc_controller->irq) {
-               ret = -ENODEV;
+       if (udc_controller->irq <= 0) {
+               ret = udc_controller->irq ? : -ENODEV;
                goto err_iounmap;
        }