net: stmmac: dwmac-rk: Don't set the regulator voltage for phy from the driver
authorRomain Perier <romain.perier@gmail.com>
Tue, 20 Jan 2015 07:09:37 +0000 (07:09 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sun, 25 Jan 2015 01:17:07 +0000 (17:17 -0800)
As these settings can be directly expressed from devicetree for both fixed
regulators and pmic-integrated regulators, it is more standard to set them
from dts and let the regulator framework use the right voltage informations
when it is used in the driver.

Signed-off-by: Romain Perier <romain.perier@gmail.com>
Tested-by: Heiko Stuebner <heiko@sntech.de>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c

index 35f9b86..06e1637 100644 (file)
@@ -303,7 +303,6 @@ static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable)
        } else {
                if (enable) {
                        if (!regulator_is_enabled(ldo)) {
-                               regulator_set_voltage(ldo, 3300000, 3300000);
                                ret = regulator_enable(ldo);
                                if (ret != 0)
                                        dev_err(dev, "%s: fail to enable %s\n",