firmware: arm_scmi: Fix type error assignment in voltage protocol
authorCristian Marussi <cristian.marussi@arm.com>
Mon, 15 Nov 2021 15:40:42 +0000 (15:40 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 1 Dec 2021 08:04:56 +0000 (09:04 +0100)
commit 026d9835b62bba34b7e657a0bfb76717822f9319 upstream.

Fix incorrect type assignment error reported by sparse as:

drivers/firmware/arm_scmi/voltage.c:159:42: warning: incorrect type in assignment (different base types)
drivers/firmware/arm_scmi/voltage.c:159:42: expected restricted __le32 [usertype] level_index
drivers/firmware/arm_scmi/voltage.c:159:42: got unsigned int [usertype] desc_index

Link: https://lore.kernel.org/r/20211115154043.49284-1-cristian.marussi@arm.com
Fixes: 2add5cacff353 ("firmware: arm_scmi: Add voltage domain management protocol support")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firmware/arm_scmi/voltage.c

index a504895..ac08e81 100644 (file)
@@ -156,7 +156,7 @@ static int scmi_voltage_descriptors_get(const struct scmi_protocol_handle *ph,
                        int cnt;
 
                        cmd->domain_id = cpu_to_le32(v->id);
-                       cmd->level_index = desc_index;
+                       cmd->level_index = cpu_to_le32(desc_index);
                        ret = ph->xops->do_xfer(ph, tl);
                        if (ret)
                                break;