lavapipe: clamp attachment clear rect sizes
authorMike Blumenkrantz <michael.blumenkrantz@gmail.com>
Mon, 4 Oct 2021 15:48:55 +0000 (11:48 -0400)
committerMarge Bot <eric+marge@anholt.net>
Tue, 19 Oct 2021 01:18:24 +0000 (01:18 +0000)
this is a spec violation, but crashing isn't cool, so do a little clamping

Reviewed-by: Dave Airlie <airlied@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13349>

src/gallium/frontends/lavapipe/lvp_execute.c

index 5f2dde2..426dea5 100644 (file)
@@ -2996,6 +2996,9 @@ static void handle_clear_attachments(struct vk_cmd_queue_entry *cmd,
       for (uint32_t r = 0; r < cmd->u.clear_attachments.rect_count; r++) {
 
          VkClearRect *rect = &cmd->u.clear_attachments.rects[r];
+         /* avoid crashing on spec violations */
+         rect->rect.extent.width = MIN2(rect->rect.extent.width, state->framebuffer.width - rect->rect.offset.x);
+         rect->rect.extent.height = MIN2(rect->rect.extent.height, state->framebuffer.height - rect->rect.offset.y);
          if (subpass->view_mask) {
             u_foreach_bit(i, subpass->view_mask)
                clear_attachment_layers(state, imgv, &rect->rect,