projects
/
kernel
/
kernel-generic.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9fd8d0e
)
block: don't init rq fields unnecessarily
author
Tejun Heo
<tj@kernel.org>
Tue, 28 Apr 2009 04:06:05 +0000
(13:06 +0900)
committer
Jens Axboe
<jens.axboe@oracle.com>
Tue, 28 Apr 2009 06:14:50 +0000
(08:14 +0200)
blk_get_request() always returns properly zeroed requests. Don't set
fields to zero/NULL unnecessarily.
[ Impact: cleanup ]
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
block/scsi_ioctl.c
patch
|
blob
|
history
diff --git
a/block/scsi_ioctl.c
b/block/scsi_ioctl.c
index
bb9aa43
..
58cf456
100644
(file)
--- a/
block/scsi_ioctl.c
+++ b/
block/scsi_ioctl.c
@@
-500,8
+500,6
@@
static int __blk_send_generic(struct request_queue *q, struct gendisk *bd_disk,
rq = blk_get_request(q, WRITE, __GFP_WAIT);
rq->cmd_type = REQ_TYPE_BLOCK_PC;
- rq->data_len = 0;
- rq->extra_len = 0;
rq->timeout = BLK_DEFAULT_SG_TIMEOUT;
rq->cmd[0] = cmd;
rq->cmd[4] = data;