mips: ralink: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 14:57:39 +0000 (15:57 +0100)
committerPaul Burton <paul.burton@mips.com>
Tue, 22 Jan 2019 19:17:20 +0000 (11:17 -0800)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: John Crispin <john@phrozen.org>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Paul Burton <paul.burton@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: linux-mips@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Burton <paul.burton@mips.com>
arch/mips/ralink/bootrom.c

index e1fa597..648f5eb 100644 (file)
@@ -35,13 +35,7 @@ static const struct file_operations bootrom_file_ops = {
 
 static int bootrom_setup(void)
 {
-       if (!debugfs_create_file("bootrom", 0444,
-                       NULL, NULL, &bootrom_file_ops)) {
-               pr_err("Failed to create bootrom debugfs file\n");
-
-               return -EINVAL;
-       }
-
+       debugfs_create_file("bootrom", 0444, NULL, NULL, &bootrom_file_ops);
        return 0;
 }