spi: hisi-sfc-v3xx: fix potential irq race condition
authorYicong Yang <yangyicong@hisilicon.com>
Mon, 12 Apr 2021 11:58:27 +0000 (19:58 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 12 Apr 2021 16:07:37 +0000 (17:07 +0100)
We mask the irq when the command completion is timeout. This won't
stop the already running irq handler. Use sychronize_irq() after
we mask the irq, to make sure there is no running handler.

Acked-by: John Garry <john.garry@huawei.com>
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Link: https://lore.kernel.org/r/1618228708-37949-2-git-send-email-yangyicong@hisilicon.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-hisi-sfc-v3xx.c

index 385eb7b..0d9e103 100644 (file)
@@ -342,6 +342,7 @@ static int hisi_sfc_v3xx_generic_exec_op(struct hisi_sfc_v3xx_host *host,
                        ret = 0;
 
                hisi_sfc_v3xx_disable_int(host);
+               synchronize_irq(host->irq);
                host->completion = NULL;
        } else {
                ret = hisi_sfc_v3xx_wait_cmd_idle(host);