report error when trying to declare private construct properties, patch by

2008-03-21  Juerg Billeter  <j@bitron.ch>

	* vala/valasemanticanalyzer.vala: report error when trying to
	  declare private construct properties,
	  patch by Daniel Silverstone, fixes bug 522685

svn path=/trunk/; revision=1146

diff --git a/ChangeLog b/ChangeLog
index 31d3951..776430a 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2008-03-21  Jürg Billeter  <j@bitron.ch>
 
+       * vala/valasemanticanalyzer.vala: report error when trying to
+         declare private construct properties,
+         patch by Daniel Silverstone, fixes bug 522685
+
+2008-03-21  Jürg Billeter  <j@bitron.ch>
+
        * vala/valaenum.vala, vala/valaenumvalue.vala,
          vala/valainterfacewriter.vala, gobject/valaccodegenerator.vala,
          gobject/valaccodegeneratorinterface.vala,

diff --git a/vala/valasemanticanalyzer.vala b/vala/valasemanticanalyzer.vala
index c868d51..257ea83 100644 (file)
--- a/vala/valasemanticanalyzer.vala
+++ b/vala/valasemanticanalyzer.vala
@@ -629,6 +629,14 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
                                }
                        }
                }
+
+               /* construct properties must be public */
+               if (prop.set_accessor != null && prop.set_accessor.construction) {
+                       if (prop.access != SymbolAccessibility.PUBLIC) {
+                               prop.error = true;
+                               Report.error (prop.source_reference, "%s: construct properties must be public".printf (prop.get_full_name ()));
+                       }
+               }
        }
 
        public override void visit_property_accessor (PropertyAccessor! acc) {