IB/hfi1: Fix error return code in parse_platform_config()
authorWang Wensheng <wangwensheng4@huawei.com>
Thu, 8 Apr 2021 11:31:40 +0000 (11:31 +0000)
committerJason Gunthorpe <jgg@nvidia.com>
Mon, 12 Apr 2021 18:10:19 +0000 (15:10 -0300)
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 7724105686e7 ("IB/hfi1: add driver files")
Link: https://lore.kernel.org/r/20210408113140.103032-1-wangwensheng4@huawei.com
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/infiniband/hw/hfi1/firmware.c

index 0e83d4b..2cf102b 100644 (file)
@@ -1916,6 +1916,7 @@ int parse_platform_config(struct hfi1_devdata *dd)
                        dd_dev_err(dd, "%s: Failed CRC check at offset %ld\n",
                                   __func__, (ptr -
                                   (u32 *)dd->platform_config.data));
+                       ret = -EINVAL;
                        goto bail;
                }
                /* Jump the CRC DWORD */