Don't leak the pipes to child processes. Patch by Thiago Macieira.

        * glib/gmain.c (g_main_context_init_pipe): Don't leak the
        pipes to child processes. Patch by Thiago Macieira.

svn path=/trunk/; revision=7037

diff --git a/ChangeLog b/ChangeLog
index 7b1ec03..1b9b1a1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-06-13  Matthias Clasen  <mclasen@redhat.com>
+
+       Bug 538119 – glib's mainloop leaks a pipe to sub-processes
+
+       * glib/gmain.c (g_main_context_init_pipe): Don't leak the
+       pipes to child processes. Patch by Thiago Macieira.
+
 2008-06-13  Hans Breuer  <hans@breuer.org>
 
        * glib/gstrfuncs.c : to get the default translation target on

diff --git a/glib/gmain.c b/glib/gmain.c
index b0c274c..b207ab7 100644 (file)
--- a/glib/gmain.c
+++ b/glib/gmain.c
@@ -669,7 +669,10 @@ g_main_context_init_pipe (GMainContext *context)
   if (pipe (context->wake_up_pipe) < 0)
     g_error ("Cannot create pipe main loop wake-up: %s\n",
             g_strerror (errno));
-  
+ 
+  fcntl (context->wake_up_pipe[0], F_SETFD, FD_CLOEXEC);
+  fcntl (context->wake_up_pipe[1], F_SETFD, FD_CLOEXEC);
+
   context->wake_up_rec.fd = context->wake_up_pipe[0];
   context->wake_up_rec.events = G_IO_IN;
 # else