OMAPDSS: DISPC: fix loop in error handler
authorTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 24 Oct 2012 06:20:40 +0000 (09:20 +0300)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Mon, 29 Oct 2012 10:44:43 +0000 (12:44 +0200)
The dispc's error handler has a loop inside another loop, and both use
the same loop variable. This is clearly wrong, and this patch makes a
new variable for the inner loop.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/omap2/dss/dispc.c

index d294873..070ce30 100644 (file)
@@ -3901,6 +3901,7 @@ static void dispc_error_worker(struct work_struct *work)
                bit = mgr_desc[i].sync_lost_irq;
 
                if (bit & errors) {
+                       int j;
                        struct omap_dss_device *dssdev = mgr->get_device(mgr);
                        bool enable;
 
@@ -3911,9 +3912,9 @@ static void dispc_error_worker(struct work_struct *work)
                        enable = dssdev->state == OMAP_DSS_DISPLAY_ACTIVE;
                        dssdev->driver->disable(dssdev);
 
-                       for (i = 0; i < omap_dss_get_num_overlays(); ++i) {
+                       for (j = 0; j < omap_dss_get_num_overlays(); ++j) {
                                struct omap_overlay *ovl;
-                               ovl = omap_dss_get_overlay(i);
+                               ovl = omap_dss_get_overlay(j);
 
                                if (ovl->id != OMAP_DSS_GFX &&
                                                ovl->manager == mgr)