tty: serial: samsung: Use bit manipulation macros for APPLE_S5L_*
authorNick Chan <towinchenmi@gmail.com>
Wed, 11 Sep 2024 05:02:11 +0000 (13:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 11 Sep 2024 13:47:13 +0000 (15:47 +0200)
New entries using BIT() will be added soon, so change the existing ones to
use bit manipulation macros including BIT() and GENMASK() for
consistency.

Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Janne Grunau <j@jannau.net>
Reviewed-by: Neal Gompa <neal@gompa.dev>
Signed-off-by: Nick Chan <towinchenmi@gmail.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20240911050741.14477-2-towinchenmi@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/serial_s3c.h

index 1672cf0810ef549abab33601f085a9ba3b445d58..2a934e20ca4b7583690da7116a6ee95c2e2b74f1 100644 (file)
 #define APPLE_S5L_UCON_RXTO_ENA                9
 #define APPLE_S5L_UCON_RXTHRESH_ENA    12
 #define APPLE_S5L_UCON_TXTHRESH_ENA    13
-#define APPLE_S5L_UCON_RXTO_ENA_MSK    (1 << APPLE_S5L_UCON_RXTO_ENA)
-#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK        (1 << APPLE_S5L_UCON_RXTHRESH_ENA)
-#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK        (1 << APPLE_S5L_UCON_TXTHRESH_ENA)
+#define APPLE_S5L_UCON_RXTO_ENA_MSK    BIT(APPLE_S5L_UCON_RXTO_ENA)
+#define APPLE_S5L_UCON_RXTHRESH_ENA_MSK        BIT(APPLE_S5L_UCON_RXTHRESH_ENA)
+#define APPLE_S5L_UCON_TXTHRESH_ENA_MSK        BIT(APPLE_S5L_UCON_TXTHRESH_ENA)
 
 #define APPLE_S5L_UCON_DEFAULT         (S3C2410_UCON_TXIRQMODE | \
                                         S3C2410_UCON_RXIRQMODE | \
                                         APPLE_S5L_UCON_RXTHRESH_ENA_MSK | \
                                         APPLE_S5L_UCON_TXTHRESH_ENA_MSK)
 
-#define APPLE_S5L_UTRSTAT_RXTHRESH     (1<<4)
-#define APPLE_S5L_UTRSTAT_TXTHRESH     (1<<5)
-#define APPLE_S5L_UTRSTAT_RXTO         (1<<9)
-#define APPLE_S5L_UTRSTAT_ALL_FLAGS    (0x3f0)
+#define APPLE_S5L_UTRSTAT_RXTHRESH     BIT(4)
+#define APPLE_S5L_UTRSTAT_TXTHRESH     BIT(5)
+#define APPLE_S5L_UTRSTAT_RXTO         BIT(9)
+#define APPLE_S5L_UTRSTAT_ALL_FLAGS    GENMASK(9, 4)
 
 #ifndef __ASSEMBLY__