Change to get stub proc name from hal-api-common 29/321329/1 accepted/tizen/unified/20250322.012727 accepted/tizen/unified/x/20250323.134016
authorSangYoun Kwak <sy.kwak@samsung.com>
Wed, 19 Mar 2025 04:50:59 +0000 (13:50 +0900)
committerSangYoun Kwak <sy.kwak@samsung.com>
Wed, 19 Mar 2025 04:50:59 +0000 (13:50 +0900)
Since the stub proc name can be vary, it should not be hard-coded but
synced with the stub.
To accomplish this, an api function from the hal-api-common is used:
hal_common_get_stub_proc_name().
This function returns stub proc name which created dynamically in the
build time.

Change-Id: I3ac5334d81edf1e7b2f672177c6cbadc1282ac73
Signed-off-by: SangYoun Kwak <sy.kwak@samsung.com>
include/hal-codec-ipc.h
src/hal-api-codec-ipc.c

index 749d0f139ee8c446940ffbc7e33946be1c5847b1..b252b17973a8964860ada0032587143bfc32fd2e 100644 (file)
@@ -24,8 +24,6 @@ extern "C" {
 #endif
 
 
-#define HAL_BACKEND_SERVICE_APPID               "d::HalBackendService"
-
 #define HAL_CODEC_IPC_PARAM_KEY_BUFFER          "HAL_CODEC_BUFFER_S"
 #define HAL_CODEC_IPC_PARAM_KEY_PLANE0_DATA     "HAL_CODEC_PLANE0"
 #define HAL_CODEC_IPC_PARAM_KEY_PLANE1_DATA     "HAL_CODEC_PLANE1"
index c39b01e39ed6ecd5eb056343fd1a5ff9f2fefbe8..17a1f0dbc3a11672239cdfbaba7dec97f267cd4c 100644 (file)
@@ -291,15 +291,22 @@ int hal_codec_ipc_init(hal_codec_type_e type, void **codec_handle)
                .disconnected = __hal_codec_ipc_disconnected,
                .rejected = __hal_codec_ipc_rejected
        };
+       const char *stub_proc_name = NULL;
 
        HAL_CODEC_RETURN_VAL_IF_FAILED(codec_handle, HAL_CODEC_ERROR_INVALID_PARAMETER);
 
        SLOGI("start");
 
+       ret = hal_common_get_stub_proc_name(HAL_MODULE_CODEC, &stub_proc_name);
+       if (ret != 0) {
+               SLOGE("Failed to get stub proc name for codec: ret(%d)", ret);
+               return ret;
+       }
+
        new_handle = g_new0(hal_codec_ipc_s, 1);
 
-       ret = rpc_port_proxy_codec_create(HAL_BACKEND_SERVICE_APPID,
-               &rpc_callbacks, NULL, &new_handle->rpc_handle);
+       ret = rpc_port_proxy_codec_create(stub_proc_name, &rpc_callbacks, NULL,
+                       &new_handle->rpc_handle);
        if (ret != RPC_PORT_ERROR_NONE) {
                SLOGE("RPC handle failed[0x%x]", ret);
                g_free(new_handle);