net: mvpp2: use RSS only when using multi-queue mode
authorYan Markman <ymarkman@marvell.com>
Thu, 12 Jul 2018 11:54:14 +0000 (13:54 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Jul 2018 00:30:48 +0000 (17:30 -0700)
Since RSS only applies when we have per-cpu rx queues, it should only
be enabled when the driver is configured to make use of multi-queue
mode.

Signed-off-by: Yan Markman <ymarkman@marvell.com>
[Maxime: Commit message]
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

index b1d812b..75aa0de 100644 (file)
@@ -3276,6 +3276,11 @@ static void mvpp2_irqs_deinit(struct mvpp2_port *port)
        }
 }
 
+static bool mvpp22_rss_is_supported(void)
+{
+       return queue_mode == MVPP2_QDIST_MULTI_MODE;
+}
+
 static int mvpp2_open(struct net_device *dev)
 {
        struct mvpp2_port *port = netdev_priv(dev);
@@ -3368,7 +3373,7 @@ static int mvpp2_open(struct net_device *dev)
 
        mvpp2_start_dev(port);
 
-       if (priv->hw_version == MVPP22)
+       if (mvpp22_rss_is_supported())
                mvpp22_init_rss(port);
 
        /* Start hardware statistics gathering */