test: fix a few scan-build errors about dead storage
authorPeter Hutterer <peter.hutterer@who-t.net>
Wed, 19 Feb 2020 03:06:18 +0000 (13:06 +1000)
committerPeter Hutterer <peter.hutterer@who-t.net>
Wed, 19 Feb 2020 03:06:18 +0000 (13:06 +1000)
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
test/test-common.c
test/test-libevdev-events.c

index 27be0f94b5a216c9c679a6d53994e3cfe97e42a0..54d5767e75c23d458eec5d98e21dd6f9b4b467ba 100644 (file)
@@ -89,6 +89,7 @@ void test_create_abs_device(struct uinput_device **uidev_return,
 
        va_start(args, abs);
        rc = uinput_device_set_event_bits_v(uidev, args);
+       ck_assert_msg(rc == 0, "Failed to set uinput bits");
        va_end(args);
 
        while (--nabs >= 0) {
index fe3938bf21df380cae1abc0bbd6ae4114b7e4702..7ed543b071be8801e1f66abeaf3d12a4bbd72adf 100644 (file)
@@ -1670,7 +1670,7 @@ START_TEST(test_mt_slot_ranges_invalid)
 
        libevdev_set_log_function(test_logfunc_ignore_error, NULL);
 
-       rc = libevdev_next_event(dev, LIBEVDEV_READ_FLAG_NORMAL, ev);
+       libevdev_next_event(dev, LIBEVDEV_READ_FLAG_NORMAL, ev);
        ck_assert(libevdev_event_is_code(ev, EV_ABS, ABS_MT_SLOT));
        ck_assert_int_eq(ev[0].value, num_slots - 1);
 
@@ -1686,7 +1686,7 @@ START_TEST(test_mt_slot_ranges_invalid)
        rc = write(pipefd[1], ev, sizeof(ev));
        ck_assert_int_eq(rc, sizeof(ev));
 
-       rc = libevdev_next_event(dev, LIBEVDEV_READ_FLAG_NORMAL, ev);
+       libevdev_next_event(dev, LIBEVDEV_READ_FLAG_NORMAL, ev);
        ck_assert(libevdev_event_is_code(ev, EV_ABS, ABS_MT_SLOT));
        ck_assert_int_eq(ev[0].value, num_slots - 1);