Rename warnUnorderableSymbol maybeWarnUnorderableSymbol because the function doesn...

llvm-svn: 345393

diff --git a/lld/ELF/Driver.cpp b/lld/ELF/Driver.cpp
index 929adacb2218b514db1db664a2ab2503f9ca6cac..17f15d8e016ead7ff149051d3e7a8468913ac5f2 100644 (file)
--- a/lld/ELF/Driver.cpp
+++ b/lld/ELF/Driver.cpp
@@ -662,8 +662,8 @@ static void readCallGraph(MemoryBufferRef MB) {
         warn(MB.getBufferIdentifier() + ": no such symbol: " + Name);
       return nullptr;
     }
+    maybeWarnUnorderableSymbol(Sym);
 
-    warnUnorderableSymbol(Sym);
     if (Defined *DR = dyn_cast_or_null<Defined>(Sym))
       return dyn_cast_or_null<InputSectionBase>(DR->Section);
     return nullptr;

diff --git a/lld/ELF/Symbols.cpp b/lld/ELF/Symbols.cpp
index 9073d21eab7a57242175f754656ff1753e50c9e7..5f7d95381b489e64896bc4b329fa792d437a8d26 100644 (file)
--- a/lld/ELF/Symbols.cpp
+++ b/lld/ELF/Symbols.cpp
@@ -260,7 +260,7 @@ void elf::printTraceSymbol(Symbol *Sym) {
   message(toString(Sym->File) + S + Sym->getName());
 }
 
-void elf::warnUnorderableSymbol(const Symbol *Sym) {
+void elf::maybeWarnUnorderableSymbol(const Symbol *Sym) {
   if (!Config->WarnSymbolOrdering)
     return;
 

diff --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
index 7a9fbe4c6ffca11e70a4df9a64fc08c902f6fdb1..a6c5697a6979a5d731ae01b42806076b7b351d66 100644 (file)
--- a/lld/ELF/Symbols.h
+++ b/lld/ELF/Symbols.h
@@ -405,7 +405,7 @@ void replaceSymbol(Symbol *S, ArgT &&... Arg) {
     printTraceSymbol(S);
 }
 
-void warnUnorderableSymbol(const Symbol *Sym);
+void maybeWarnUnorderableSymbol(const Symbol *Sym);
 } // namespace elf
 } // namespace lld
 

diff --git a/lld/ELF/Writer.cpp b/lld/ELF/Writer.cpp
index cd3f0806c3d6251b7b478ef39e91bb55402492c6..e486a77e7c5666ff692cc65b9867d9ef92c65bd8 100644 (file)
--- a/lld/ELF/Writer.cpp
+++ b/lld/ELF/Writer.cpp
@@ -1105,7 +1105,7 @@ static DenseMap<const InputSectionBase *, int> buildSectionOrder() {
     SymbolOrderEntry &Ent = It->second;
     Ent.Present = true;
 
-    warnUnorderableSymbol(&Sym);
+    maybeWarnUnorderableSymbol(&Sym);
 
     if (auto *D = dyn_cast<Defined>(&Sym)) {
       if (auto *Sec = dyn_cast_or_null<InputSectionBase>(D->Section)) {