Ouch: gst_element_dispose does a state change to NULL. Change the state to NULL yours...

Original commit message from CVS:
Ouch: gst_element_dispose does a state change to NULL. Change the state to NULL yourself if you dispose plugins that reference some of the freed memory on state changes.

This is probably broken in lots of cases.

diff --git a/gst/gstqueue.c b/gst/gstqueue.c
index a24dcb64ff5ee75ebbe31814f7b3869143fed335..a2c56cd7f6c55292f89c575891716b1b852af1a5 100644 (file)
--- a/gst/gstqueue.c
+++ b/gst/gstqueue.c
@@ -251,7 +251,7 @@ gst_queue_dispose (GObject *object)
 {
   GstQueue *queue = GST_QUEUE (object);
 
-  gst_queue_locked_flush (queue);
+  gst_element_set_state (GST_ELEMENT (queue), GST_STATE_NULL);
 
   g_mutex_free (queue->qlock);
   g_cond_free (queue->not_empty);

diff --git a/plugins/elements/gstqueue.c b/plugins/elements/gstqueue.c
index a24dcb64ff5ee75ebbe31814f7b3869143fed335..a2c56cd7f6c55292f89c575891716b1b852af1a5 100644 (file)
--- a/plugins/elements/gstqueue.c
+++ b/plugins/elements/gstqueue.c
@@ -251,7 +251,7 @@ gst_queue_dispose (GObject *object)
 {
   GstQueue *queue = GST_QUEUE (object);
 
-  gst_queue_locked_flush (queue);
+  gst_element_set_state (GST_ELEMENT (queue), GST_STATE_NULL);
 
   g_mutex_free (queue->qlock);
   g_cond_free (queue->not_empty);