net: Use g_strdup_printf instead of snprintf.
authorHani Benhabiles <kroosec@gmail.com>
Thu, 9 Jan 2014 18:34:27 +0000 (19:34 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 27 Jan 2014 14:44:06 +0000 (15:44 +0100)
assign_name() in net/net.c is using snprintf + g_strdup to get the same
result as g_strdup_printf.

Signed-off-by: Hani Benhabiles <kroosec@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
net/net.c

index f8db85f30b41973b1973ff5d21020994a7292105..2c3af202a60d72e40a871f467a3d7f04f4a431ba 100644 (file)
--- a/net/net.c
+++ b/net/net.c
@@ -164,7 +164,6 @@ void qemu_macaddr_default_if_unset(MACAddr *macaddr)
 static char *assign_name(NetClientState *nc1, const char *model)
 {
     NetClientState *nc;
-    char buf[256];
     int id = 0;
 
     QTAILQ_FOREACH(nc, &net_clients, next) {
@@ -176,9 +175,7 @@ static char *assign_name(NetClientState *nc1, const char *model)
         }
     }
 
-    snprintf(buf, sizeof(buf), "%s.%d", model, id);
-
-    return g_strdup(buf);
+    return g_strdup_printf("%s.%d", model, id);
 }
 
 static void qemu_net_client_destructor(NetClientState *nc)