Staging: line6: NULL dereference in dev_err()

"line6" hasn't been set at this point and we should be using
&interface->dev instead.

Gcc would have complained about this if it weren't for the fact that we
initialized line6 to NULL.  I removed the initialization.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
index a71a5af..a2f48ee 100644 (file)
--- a/drivers/staging/line6/driver.c
+++ b/drivers/staging/line6/driver.c
@@ -726,8 +726,8 @@ static int line6_probe(struct usb_interface *interface,
                       const struct usb_device_id *id)
 {
        int devtype;
-       struct usb_device *usbdev = NULL;
-       struct usb_line6 *line6 = NULL;
+       struct usb_device *usbdev;
+       struct usb_line6 *line6;
        const struct line6_properties *properties;
        int devnum;
        int interface_number, alternate = 0;
@@ -936,7 +936,7 @@ static int line6_probe(struct usb_interface *interface,
        }
 
        if (size == 0) {
-               dev_err(line6->ifcdev,
+               dev_err(&interface->dev,
                        "driver bug: interface data size not set\n");
                ret = -ENODEV;
                goto err_put;