PCI: Constify hotplug attribute_group structures
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Tue, 11 Jul 2017 09:28:44 +0000 (14:58 +0530)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 10 Aug 2017 20:21:41 +0000 (15:21 -0500)
attribute_groups are not supposed to change at runtime.  All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group.  So mark the non-const structs as const.

File size before:
   text    data     bss     dec     hex filename
    418     160       8     586     24a drivers/pci/hotplug/rpadlpar_sysfs.o

File size After adding 'const':
   text    data     bss     dec     hex filename
    482      96       8     586     232 drivers/pci/hotplug/rpadlpar_sysfs.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
drivers/pci/hotplug/rpadlpar_sysfs.c

index a796301..edb5d8a 100644 (file)
@@ -102,7 +102,7 @@ static struct attribute *default_attrs[] = {
        NULL,
 };
 
-static struct attribute_group dlpar_attr_group = {
+static const struct attribute_group dlpar_attr_group = {
        .attrs = default_attrs,
 };