e1000e: remove test that is always false
authorBruce Allan <bruce.w.allan@intel.com>
Tue, 31 Jan 2012 06:37:59 +0000 (06:37 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 10 Feb 2012 08:06:07 +0000 (00:06 -0800)
warning: comparison of unsigned expression < 0 is always false

Remove an unnecessary test that is reported when compiling driver with W=1.
The test is unnecessary because Intel wired GbE hardware older (i.e. less)
than 82571 is not supported by this driver.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/mac.c

index e1cf107..33d1b9e 100644 (file)
@@ -174,8 +174,8 @@ s32 e1000_check_alt_mac_addr_generic(struct e1000_hw *hw)
        if (ret_val)
                goto out;
 
-       /* not supported on older hardware or 82573 */
-       if ((hw->mac.type < e1000_82571) || (hw->mac.type == e1000_82573))
+       /* not supported on 82573 */
+       if (hw->mac.type == e1000_82573)
                goto out;
 
        ret_val = e1000_read_nvm(hw, NVM_ALT_MAC_ADDR_PTR, 1,