ethernet: ti: am65-cpts: Use generic helper function
authorKurt Kanzenbach <kurt@linutronix.de>
Tue, 18 Aug 2020 10:32:47 +0000 (12:32 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 19 Aug 2020 23:07:49 +0000 (16:07 -0700)
In order to reduce code duplication between ptp drivers, generic helper
functions were introduced. Use them.

Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/am65-cpts.c

index c59a289e428c95e68533e2c1efe79b3b537f2832..365b5b9c6897a52d3240fb18fb203aaa31e413ce 100644 (file)
@@ -748,42 +748,23 @@ EXPORT_SYMBOL_GPL(am65_cpts_rx_enable);
 static int am65_skb_get_mtype_seqid(struct sk_buff *skb, u32 *mtype_seqid)
 {
        unsigned int ptp_class = ptp_classify_raw(skb);
-       u8 *msgtype, *data = skb->data;
-       unsigned int offset = 0;
-       __be16 *seqid;
+       struct ptp_header *hdr;
+       u8 msgtype;
+       u16 seqid;
 
        if (ptp_class == PTP_CLASS_NONE)
                return 0;
 
-       if (ptp_class & PTP_CLASS_VLAN)
-               offset += VLAN_HLEN;
-
-       switch (ptp_class & PTP_CLASS_PMASK) {
-       case PTP_CLASS_IPV4:
-               offset += ETH_HLEN + IPV4_HLEN(data + offset) + UDP_HLEN;
-               break;
-       case PTP_CLASS_IPV6:
-               offset += ETH_HLEN + IP6_HLEN + UDP_HLEN;
-               break;
-       case PTP_CLASS_L2:
-               offset += ETH_HLEN;
-               break;
-       default:
-               return 0;
-       }
-
-       if (skb->len + ETH_HLEN < offset + OFF_PTP_SEQUENCE_ID + sizeof(*seqid))
+       hdr = ptp_parse_header(skb, ptp_class);
+       if (!hdr)
                return 0;
 
-       if (unlikely(ptp_class & PTP_CLASS_V1))
-               msgtype = data + offset + OFF_PTP_CONTROL;
-       else
-               msgtype = data + offset;
+       msgtype = ptp_get_msgtype(hdr, ptp_class);
+       seqid   = ntohs(hdr->sequence_id);
 
-       seqid = (__be16 *)(data + offset + OFF_PTP_SEQUENCE_ID);
-       *mtype_seqid = (*msgtype << AM65_CPTS_EVENT_1_MESSAGE_TYPE_SHIFT) &
+       *mtype_seqid  = (msgtype << AM65_CPTS_EVENT_1_MESSAGE_TYPE_SHIFT) &
                        AM65_CPTS_EVENT_1_MESSAGE_TYPE_MASK;
-       *mtype_seqid |= (ntohs(*seqid) & AM65_CPTS_EVENT_1_SEQUENCE_ID_MASK);
+       *mtype_seqid |= (seqid & AM65_CPTS_EVENT_1_SEQUENCE_ID_MASK);
 
        return 1;
 }