tests/check/pipelines/vorbisenc.c: Move a g_cond_signal to earlier to avoid sometimes...

Original commit message from CVS:
* tests/check/pipelines/vorbisenc.c: (stop_pipeline):
Move a g_cond_signal to earlier to avoid sometimes deadlocking
(commonly happens when running this test under valgrind) when trying
to remove the buffer probe.

diff --git a/ChangeLog b/ChangeLog
index 09d520e..c51e4d9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2006-07-14  Michael Smith  <msmith@fluendo.com>
+
+       * tests/check/pipelines/vorbisenc.c: (stop_pipeline):
+         Move a g_cond_signal to earlier to avoid sometimes deadlocking
+         (commonly happens when running this test under valgrind) when trying
+         to remove the buffer probe.
+
 2006-07-13  Jan Schmidt  <thaytan@mad.scientist.com>
 
        * sys/xvimage/xvimagesink.c: (gst_xvimagesink_xvimage_new):

diff --git a/tests/check/pipelines/vorbisenc.c b/tests/check/pipelines/vorbisenc.c
index 57cdd92..395588d 100644 (file)
--- a/tests/check/pipelines/vorbisenc.c
+++ b/tests/check/pipelines/vorbisenc.c
@@ -87,9 +87,9 @@ stop_pipeline (GstElement * bin, GstPad * pad)
   if (buf)
     gst_buffer_unref (buf);
   buf = NULL;
+  g_cond_signal (cond);
   gst_pad_remove_buffer_probe (pad, (guint) id);
   id = 0;
-  g_cond_signal (cond);
   g_mutex_unlock (lock);
 
   gst_element_set_state (bin, GST_STATE_NULL);