Use getSize instead of data().size(). NFC.
authorRafael Espindola <rafael.espindola@gmail.com>
Mon, 3 Oct 2016 17:49:19 +0000 (17:49 +0000)
committerRafael Espindola <rafael.espindola@gmail.com>
Mon, 3 Oct 2016 17:49:19 +0000 (17:49 +0000)
Also assert isFinalized in getSize(). This just reduces the noise from
another patch.

llvm-svn: 283125

llvm/include/llvm/MC/StringTableBuilder.h
llvm/lib/MC/MachObjectWriter.cpp
llvm/lib/MC/StringTableBuilder.cpp
llvm/tools/yaml2obj/yaml2elf.cpp

index f2b8ecd2d99786d11acd50d3c01643f6c34d5b7f..c8908c384c80315b860f869b910916b3108dbf1f 100644 (file)
@@ -61,7 +61,7 @@ public:
     return StringIndexMap;
   }
 
-  size_t getSize() const { return Size; }
+  size_t getSize() const;
   void clear();
 
 private:
index e39271949d94210a8b6f934ffc1f900261d7af5e..acb79223d4e84264dfbd7ca17e460e566b32491c 100644 (file)
@@ -882,7 +882,7 @@ void MachObjectWriter::writeObject(MCAssembler &Asm,
                                               sizeof(MachO::nlist_64) :
                                               sizeof(MachO::nlist));
     writeSymtabLoadCommand(SymbolTableOffset, NumSymTabSymbols,
-                           StringTableOffset, StringTable.data().size());
+                           StringTableOffset, StringTable.getSize());
 
     writeDysymtabLoadCommand(FirstLocalSymbol, NumLocalSymbols,
                              FirstExternalSymbol, NumExternalSymbols,
index 9d95952a6d3033611834070420927fd9462cca11..24ae9d034d2924a2044f0f3ab56736217c3afa27 100644 (file)
@@ -34,6 +34,11 @@ StringTableBuilder::StringTableBuilder(Kind K, unsigned Alignment)
   }
 }
 
+size_t StringTableBuilder::getSize() const {
+  assert(isFinalized());
+  return Size;
+}
+
 typedef std::pair<CachedHash<StringRef>, size_t> StringPair;
 
 // Returns the character at Pos from end of a string.
index c98093431a7ef65c39467a044e3f753814db1b92..60d21599613f95981c7861be2c38da820185d646 100644 (file)
@@ -307,7 +307,7 @@ void ELFState<ELFT>::initStrtabSectionHeader(Elf_Shdr &SHeader, StringRef Name,
   SHeader.sh_type = ELF::SHT_STRTAB;
   CBA.getOSAndAlignedOffset(SHeader.sh_offset, SHeader.sh_addralign)
       << STB.data();
-  SHeader.sh_size = STB.data().size();
+  SHeader.sh_size = STB.getSize();
   SHeader.sh_addralign = 1;
 }