qeth: remove a copy of the NAPI_POLL_WEIGHT define
authorJakub Kicinski <kuba@kernel.org>
Thu, 28 Apr 2022 21:23:23 +0000 (14:23 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 29 Apr 2022 10:56:42 +0000 (11:56 +0100)
Defining local versions of NAPI_POLL_WEIGHT with the same
values in the drivers just makes refactoring harder.

Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h
drivers/s390/net/qeth_core_main.c
drivers/s390/net/qeth_l2_main.c
drivers/s390/net/qeth_l3_main.c

index de25d7a..1d19542 100644 (file)
@@ -801,8 +801,6 @@ struct qeth_priv {
        u32 brport_features;
 };
 
-#define QETH_NAPI_WEIGHT NAPI_POLL_WEIGHT
-
 struct qeth_card {
        enum qeth_card_states state;
        spinlock_t lock;
index d99c5b7..ae85179 100644 (file)
@@ -7100,7 +7100,7 @@ int qeth_open(struct net_device *dev)
        local_bh_disable();
        qeth_for_each_output_queue(card, queue, i) {
                netif_tx_napi_add(dev, &queue->napi, qeth_tx_poll,
-                                 QETH_NAPI_WEIGHT);
+                                 NAPI_POLL_WEIGHT);
                napi_enable(&queue->napi);
                napi_schedule(&queue->napi);
        }
index 303461d..92698f7 100644 (file)
@@ -1133,7 +1133,7 @@ static int qeth_l2_setup_netdev(struct qeth_card *card)
                                       PAGE_SIZE * (QDIO_MAX_ELEMENTS_PER_BUFFER - 1));
        }
 
-       netif_napi_add(card->dev, &card->napi, qeth_poll, QETH_NAPI_WEIGHT);
+       netif_napi_add(card->dev, &card->napi, qeth_poll, NAPI_POLL_WEIGHT);
        return register_netdev(card->dev);
 }
 
index d2f422a..ea3b6b1 100644 (file)
@@ -1910,7 +1910,7 @@ static int qeth_l3_setup_netdev(struct qeth_card *card)
                netif_set_gso_max_size(card->dev,
                                       PAGE_SIZE * (QETH_MAX_BUFFER_ELEMENTS(card) - 1));
 
-       netif_napi_add(card->dev, &card->napi, qeth_poll, QETH_NAPI_WEIGHT);
+       netif_napi_add(card->dev, &card->napi, qeth_poll, NAPI_POLL_WEIGHT);
        return register_netdev(card->dev);
 }