media: meson-ge2d: Fix rotation parameter changes detection in 'ge2d_s_ctrl()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 30 Jul 2021 19:35:05 +0000 (21:35 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 30 Sep 2021 08:07:39 +0000 (10:07 +0200)
There is likely a typo here. To be consistent, we should compare
'fmt.height' with 'ctx->out.pix_fmt.height', not 'ctx->out.pix_fmt.width'.

Instead of fixing the test, just remove it and copy 'fmt' unconditionally.

Fixes: 59a635327ca7 ("media: meson: Add M2M driver for the Amlogic GE2D Accelerator Unit")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/meson/ge2d/ge2d.c

index a1393fe..9b1e973 100644 (file)
@@ -779,11 +779,7 @@ static int ge2d_s_ctrl(struct v4l2_ctrl *ctrl)
                 * If the rotation parameter changes the OUTPUT frames
                 * parameters, take them in account
                 */
-               if (fmt.width != ctx->out.pix_fmt.width ||
-                   fmt.height != ctx->out.pix_fmt.width ||
-                   fmt.bytesperline > ctx->out.pix_fmt.bytesperline ||
-                   fmt.sizeimage > ctx->out.pix_fmt.sizeimage)
-                       ctx->out.pix_fmt = fmt;
+               ctx->out.pix_fmt = fmt;
 
                break;
        }